Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tc_build/binutils: Dont install unwanted man pages and info files #286

Merged
merged 4 commits into from
Jan 30, 2025
Merged

tc_build/binutils: Dont install unwanted man pages and info files #286

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f0db9d
tc_build/binutils: Dont install unwanted man pages and info files
dakkshesh07 Jan 29, 2025
598c9fe
tc_build/binutils: Move TemporaryDirectory() usage inside a with block
dakkshesh07 Jan 29, 2025
46aa14e
tc_build/binutils: Convert `doc_dirs` into a tuple
dakkshesh07 Jan 30, 2025
7d5e40e
tc_build/binutils: Clarify the comment about TemporaryDirectory() usage
dakkshesh07 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions tc_build/binutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import os
from pathlib import Path
import platform
from tempfile import TemporaryDirectory

from tc_build.builder import Builder
from tc_build.source import SourceManager
Expand All @@ -28,6 +29,7 @@ def __init__(self):
'--quiet',
'--with-system-zlib',
]

self.configure_vars = {
'CC': 'gcc',
'CXX': 'g++',
Expand All @@ -54,18 +56,24 @@ def build(self):
self.folders.build.mkdir(exist_ok=True, parents=True)
tc_build.utils.print_header(f"Building {self.target} binutils")

configure_cmd = [
Path(self.folders.source, 'configure'),
*self.configure_flags,
] + [f"{var}={val}" for var, val in self.configure_vars.items()]
self.run_cmd(configure_cmd, cwd=self.folders.build)
# Binutils does not provide a configuration flag to disable installation of documentation directly.
# Instead, we redirect generated docs to a temporary directory, deleting them after installation.
with TemporaryDirectory() as tmpdir:
doc_dirs = ('info', 'html', 'pdf', 'man')
self.configure_flags += [f"--{doc}dir={tmpdir}" for doc in doc_dirs]

make_cmd = ['make', '-C', self.folders.build, '-s', f"-j{os.cpu_count()}", 'V=0']
self.run_cmd(make_cmd)
configure_cmd = [
Path(self.folders.source, 'configure'),
*self.configure_flags,
] + [f"{var}={val}" for var, val in self.configure_vars.items()]
self.run_cmd(configure_cmd, cwd=self.folders.build)

if self.folders.install:
self.run_cmd([*make_cmd, 'install'])
tc_build.utils.create_gitignore(self.folders.install)
make_cmd = ['make', '-C', self.folders.build, '-s', f"-j{os.cpu_count()}", 'V=0']
self.run_cmd(make_cmd)

if self.folders.install:
self.run_cmd([*make_cmd, 'install'])
tc_build.utils.create_gitignore(self.folders.install)


class StandardBinutilsBuilder(BinutilsBuilder):
Expand Down