Skip to content

Commit

Permalink
Merge pull request #506 from ClearcodeHQ/pipenv-skip-lock
Browse files Browse the repository at this point in the history
Drop pipfile.lock - rely on cached/artifact
  • Loading branch information
fizyk authored Oct 17, 2023
2 parents dad3e96 + 0c03210 commit 6b21150
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 670 deletions.
1 change: 0 additions & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
- uses: fizyk/actions-reuse/.github/actions/[email protected]
with:
python-version: ${{ matrix.python-version }}
pipenv-install-options: "--skip-lock"
command: "pytest benchmarks/ --benchmark-json output.json"
- name: Analyse benchmark results for Pull Requests
uses: rhysd/[email protected]
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ jobs:
basic_linters:
uses: fizyk/actions-reuse/.github/workflows/[email protected]
with:
pipenv-install-options: "--skip-lock"
mypy: true
black: true
ruff: true
2 changes: 0 additions & 2 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
- uses: fizyk/actions-reuse/.github/actions/[email protected]
with:
python-version: "3.12"
pipenv-install-options: "--skip-lock"
command: tbump --dry-run --only-patch $(pipenv run tbump current-version)"-x"
towncrier:
runs-on: ubuntu-latest
Expand All @@ -22,6 +21,5 @@ jobs:
- uses: fizyk/actions-reuse/.github/actions/[email protected]
with:
python-version: "3.12"
pipenv-install-options: "--skip-lock"
command: towncrier check --compare-with origin/main
fetch-depth: 0
1 change: 0 additions & 1 deletion .github/workflows/sphinx-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ jobs:
- uses: fizyk/actions-reuse/.github/actions/[email protected]
with:
python-version: "3.12"
pipenv-install-options: "--skip-lock"
command: "sphinx-build -b html docs/source build/html"
- name: Deploy
uses: peaceiris/actions-gh-pages@v3
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ jobs:
tests:
uses: fizyk/actions-reuse/.github/workflows/[email protected]
with:
pipenv-install-options: "--skip-lock"
python-versions: '["3.8", "3.9", "3.10", "3.11", "3.12", "pypy-3.8"]'
secrets:
codecov_token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ __pycache__/
*.py[cod]
venv/

# Pipenv
Pipfile.lock

# C extensions
*.so

Expand Down
664 changes: 0 additions & 664 deletions Pipfile.lock

This file was deleted.

1 change: 1 addition & 0 deletions newsfragments/506.misc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Rely on cached/artifacted Pipfile.lock on CI

0 comments on commit 6b21150

Please sign in to comment.