Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce typing and run mypy checks - cloes #474 #503

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Introduce typing and run mypy checks - cloes #474 #503

merged 1 commit into from
Jul 28, 2023

Conversation

fizyk
Copy link
Member

@fizyk fizyk commented Jul 28, 2023

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_numer either from issue tracker or the Pull request number

@fizyk fizyk force-pushed the typing branch 2 times, most recently from 4b2c8f0 to 47cf89e Compare July 28, 2023 14:07
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.43% 🎉

Comparison is base (4de00c8) 96.37% compared to head (47cf89e) 96.81%.

❗ Current head 47cf89e differs from pull request most recent head d2dcb13. Consider uploading reports for the commit d2dcb13 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   96.37%   96.81%   +0.43%     
==========================================
  Files           4        5       +1     
  Lines         138      157      +19     
==========================================
+ Hits          133      152      +19     
  Misses          5        5              
Flag Coverage Δ
elastic-7.17 96.81% <100.00%> (+0.43%) ⬆️
elastic-8.0 ?
elastic-8.3 ?
elastic-8.4 ?
elastic-8.5 ?
elastic-8.6 96.81% <100.00%> (+0.43%) ⬆️
elastic-8.8 96.81% <100.00%> (+0.43%) ⬆️
elastic-8.9 96.81% <100.00%> (+0.43%) ⬆️
linux 96.81% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pytest_elasticsearch/config.py 100.00% <100.00%> (ø)
pytest_elasticsearch/executor.py 91.66% <100.00%> (+0.36%) ⬆️
pytest_elasticsearch/factories.py 98.41% <100.00%> (ø)
pytest_elasticsearch/plugin.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fizyk fizyk merged commit 8278f21 into main Jul 28, 2023
36 checks passed
@fizyk fizyk deleted the typing branch July 28, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants