Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete and misleading paragraph from README - closes #688 #859

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

fizyk
Copy link
Member

@fizyk fizyk commented Dec 15, 2023

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_numer either from issue tracker or the Pull request number

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6fdf1d) 95.45% compared to head (9af61af) 95.45%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #859   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files          13       13           
  Lines         396      396           
=======================================
  Hits          378      378           
  Misses         18       18           
Flag Coverage Δ
unittests 95.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fizyk fizyk merged commit c19ebeb into main Dec 15, 2023
49 checks passed
@fizyk fizyk deleted the readme-fix branch December 15, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants