Create error-handling.md #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## What is error handling? | ||
|
|
||
| Applications have a expected flow, and due to external circumstances sometimes will deviate from this flow. This deviation is considered an error and has to be handled accordingly. We dive into this handling later in this spec. |
There was a problem hiding this comment.
s/a expected/an expected/
There was a problem hiding this comment.
this isn't really a spec, maybe "guide"?
There was a problem hiding this comment.
This introduction makes it seem like errors are out of our control. I might consider removing this section and leading off with the definition of "error" i.e. the "what types of errors are there" section.
|
@templaedhel this needs some love. there are lots of TBD's around herer |
|
@mohit - thanks for reminder. this has been on the backburner for awhile but I will take a look asap. |
| Across different programming languages, there are a variety of approaches to handle errors. I focus on the paradigms we've adopted at Clever based on our infrastructure (AWS, Heroku) and coding languages (CoffeeScript, Python, Go). | ||
|
|
||
| 1. CoffeeScript/Javascript | ||
| - `Error` You can subclass the builtin Error class and throw different types of errors depending on the type of failure. You can then detect where a failure came from in a central error handler. Careful doing this though, there are [gotchas](https://github.com/Clever/clever-api/pull/155). |
There was a problem hiding this comment.
this is a private link, so we should probably replace this with a link to a public version of this comment. maybe a blog post?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nathanleiby To add some final comments and tweaks, other opinions welcome.