Style #8
Merged
Style #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Clever/engineers Please review. |
| * Avoids holy wars over small details, but still encourages an approach to coding that sweats the details. | ||
|
|
||
| For each of the languages below we link to a style guide reference and outline tools to use in order to help follow the style guide. | ||
| These tools should be part of every project's build and test cycle. |
There was a problem hiding this comment.
I assume this means moving style checking to be triggered by make and/or make test (since that's how all of our projects build/test). We've discussed this as an alternative to git pre-commit hooks before and I like the idea!
Maybe this section could benefit from a short explanation of why style checking should be part of the build and test cycle as opposed to other options (e.g. running checks ad hoc, running them in git hooks).
|
|
||
| * sublime: Add [GoSublime](https://github.com/DisposaBoy/GoSublime) for code highlighting and `go fmt` on save. | ||
|
|
||
| * vim (TODO) |
There was a problem hiding this comment.
|
merging! |
rgarcia
added a commit
that referenced
this pull request
Apr 28, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.