Skip to content

Commit

Permalink
Merge pull request #498 from Clever/INFRANG-6614
Browse files Browse the repository at this point in the history
wag-js better typing for options
  • Loading branch information
ChrisScotMartin authored Nov 14, 2024
2 parents d7d4bc7 + 95fcd27 commit 10b7f17
Show file tree
Hide file tree
Showing 22 changed files with 914 additions and 1 deletion.
4 changes: 3 additions & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
v9.5.0
v9.5.1

v9.5.1 Minor bug fix in the typing of options in the generated JS client

v9.5.0 Bugfix composite keys in a GSI with no range key. Also, generated tests are only added when opted in via a new flag, instead of by default.

Expand Down
3 changes: 3 additions & 0 deletions clients/js/genjs.go
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@ const pluralParamMethodDefinitionTemplateString = `/**{{if .Description}}
* @param {{if $param.JSDocType}}{{.JSDocType}} {{end}}{{if not $param.Required}}[{{end}}params.{{$param.JSName}}{{if $param.Default}}={{$param.Default}}{{end}}{{if not $param.Required}}]{{end}}{{if $param.Description}} - {{.Description}}{{end}}{{end}}
* @param {object} [options]
* @param {number} [options.timeout] - A request specific timeout
* @param {object} [options.baggage] - A request specific baggage to be propagated
* @param {module:{{.ServiceName}}.RetryPolicies} [options.retryPolicy] - A request specific retryPolicy
{{- if .IterMethod}}
* @returns {Object} iter
Expand Down Expand Up @@ -1376,6 +1377,7 @@ interface RetryPolicy {
interface RequestOptions {
timeout?: number;
baggage?: object;
retryPolicy?: RetryPolicy;
}
Expand All @@ -1396,6 +1398,7 @@ interface CircuitOptions {
interface GenericOptions {
timeout?: number;
baggage?: object;
keepalive?: boolean;
retryPolicy?: RetryPolicy;
logger?: Logger;
Expand Down
2 changes: 2 additions & 0 deletions samples/gen-js-blog/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-blog/index.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-blog/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions samples/gen-js-client-only/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-client-only/index.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions samples/gen-js-client-only/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-db-custom-path/index.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-db/index.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-deprecated/index.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-errors/index.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions samples/gen-js-nils/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-nils/index.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions samples/gen-js-nils/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions samples/gen-js-strings/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions samples/gen-js-strings/index.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions samples/gen-js-strings/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 10b7f17

Please sign in to comment.