Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Close #845
Because this involves name changing, a lot of files changed in experiments, test.
For review, I think it is enough to focus on the changes to files in src/. @braghiere
Tagging @Espeer5 since you implemented the two stream scheme and this impacts those functions - only review as your time permits :)
To-do
Content
Previously, we computed the absorbed, reflected, and transmitted fluxes in moles of photons per m^2/s in both NIR and PAR. This required:
Content:
compute_absorbances
->compute_fractional_absorbances
,plant_absorbed_pfd
->canopy_sw_rt
(shortwave radiative transfer)I compared multiple buildkite plots (ClimaLandSims, fluxnet sites, canopy implicit timestepping, canopy without lai/sai, and all plots were identical between this and the latest PR that merged into main).