Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute surface albedo correctly #851

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Oct 14, 2024

Purpose

Close #845

Because this involves name changing, a lot of files changed in experiments, test.

For review, I think it is enough to focus on the changes to files in src/. @braghiere
Tagging @Espeer5 since you implemented the two stream scheme and this impacts those functions - only review as your time permits :)

To-do

Content

Previously, we computed the absorbed, reflected, and transmitted fluxes in moles of photons per m^2/s in both NIR and PAR. This required:

  • converting PAR and NIR downwelling energy flux -> moles of photon fluxes, which is then used to get moles photon/m^2/s absorbed, transmitted, reflected. We do this because PAR is needed in moles of photon for photosynthesis and SIF computations. But, it required then converting absorbed molar flux etc back to get total absorbed energy flux, transmitted flux, etc
  • NIR is not needed in molar flux, but we still computed it this way since we did it for PAR

Content:

  • compute fraction absorbed, reflected, transmitted
  • when a molar flux of absorbed PAR is needed, convert to it, but otherwise work in energy fluxes
  • remove lambda_gamma_NIR (typical energy per photon in the NIR) from parameters and all scripts since we do not need to convert the NIR energy flux into a moles of photon flux.
  • renamed inc_* -> *_d (incoming -> downwelling by our convention)
  • Changed names: compute_absorbances -> compute_fractional_absorbances, plant_absorbed_pfd -> canopy_sw_rt (shortwave radiative transfer)

I compared multiple buildkite plots (ClimaLandSims, fluxnet sites, canopy implicit timestepping, canopy without lai/sai, and all plots were identical between this and the latest PR that merged into main).


  • I have read and checked the items on the review checklist.

@kmdeck kmdeck self-assigned this Oct 14, 2024
Copy link
Member

@braghiere braghiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change how we calculate SW albedo.

Copy link
Collaborator

@Espeer5 Espeer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the TwoStream scheme look good and make sense to me!

@kmdeck
Copy link
Member Author

kmdeck commented Nov 13, 2024

We need to change how we calculate SW albedo.

fixed!

@kmdeck kmdeck force-pushed the kd/correct_albedo_computation branch from 35279cc to c664df7 Compare November 14, 2024 21:54
@kmdeck kmdeck dismissed braghiere’s stale review November 14, 2024 23:26

I fixed the issue

@kmdeck kmdeck merged commit e6dedef into main Nov 14, 2024
16 of 17 checks passed
@kmdeck kmdeck deleted the kd/correct_albedo_computation branch November 14, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Land surface albedo
3 participants