Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] feat: calendar card #1179

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brunosabot
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Example printscreens/gif

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Additional documentation needed.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests screenshots/gifs have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for readme.

@MrBearPresident
Copy link
Collaborator

This looks cool...
No print screens yet?

One request though. I'm also busy splitting the editor in multiple parts.
Could you move all calendar specific elements to a separate file under the calendar folder?
I can send you an example in a couple hours.

@MrBearPresident MrBearPresident marked this pull request as draft January 24, 2025 08:29
@brunosabot
Copy link
Contributor Author

@MrBearPresident I don't have much time to work on this right now. Do what you have to do with the editor and I'll adapt with your work

@brunosabot
Copy link
Contributor Author

@MrBearPresident should I base my dev on #1173 to have the future version of the editor? I can probably have time to work again on it soon.

@MrBearPresident
Copy link
Collaborator

Yes, but keep your schema-Style-form.
This is much more like the default HA-gui.

@brunosabot
Copy link
Contributor Author

@MrBearPresident I opened a new PR for this card: #1207
You can close this one if you want, but you can also be inspired with some custom cards/custom schema I wrote for the editor.
Might save you time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants