Flyweight #28

pedrodaviddev · 2017-03-30T09:22:44Z

Implemented flyweight pattern. Maybe you are thinking... why are you merging with state branch???
This is because the great @tonilopezmr said that Flyweight can be implemented with State, so I make pull to see if this can be done. And I cant see the similaritys between these patterns so, here's my version of flyweight! So much love <3

Cotel · 2017-03-30T09:33:15Z

src/main/kotlin/oop/Flyweight/SoldierFactory.kt

+import org.jetbrains.annotations.TestOnly
+
+class SoldierFactory {
+  companion object {


I think this factory can be improved. It is so Java style...

Cotel · 2017-03-30T09:34:34Z

src/main/kotlin/oop/Flyweight/Admiral.kt

+    val TYPE = 1
+  }
+  init {
+      Flyweight.objectInstances++


Dangerous ⚠️ If variable is public it can be overrided unsafely.

Cotel

Seems okay overall 👍 Now you can look how to improve this code with Kotlin style 😉

tonilopezmr

tonilopezmr · 2017-03-30T18:10:34Z

src/main/kotlin/oop/Flyweight/Admiral.kt

@@ -0,0 +1,19 @@
+package oop.Flyweight
+
+import java.awt.Point


Oh my fucking god ❌

tonilopezmr · 2017-03-30T18:10:51Z

src/main/kotlin/oop/Flyweight/Admiral.kt

+
+class Admiral : Soldier {
+  companion object {
+    val TYPE = 1


tonilopezmr · 2017-03-30T18:11:21Z

src/main/kotlin/oop/Flyweight/Admiral.kt

+      Flyweitght.objectInstances++
+  }
+
+  val attack = 6


tonilopezmr · 2017-03-30T18:11:32Z

src/main/kotlin/oop/Flyweight/Admiral.kt

+  }
+
+  val attack = 6
+  val salary = 23000


tonilopezmr · 2017-03-30T18:11:58Z

src/main/kotlin/oop/Flyweight/Captain.kt

+
+class Captain : Soldier {
+  companion object {
+    val TYPE = 2


tonilopezmr · 2017-03-30T18:13:08Z

src/main/kotlin/oop/Flyweight/Soldier.kt

@@ -0,0 +1,7 @@
+package oop.Flyweight
+
+import java.awt.Point


NOPE ❌ NOPE ❌ NOPE ❌ NOPE ❌ NOPE ❌

tonilopezmr · 2017-03-30T18:14:30Z

src/main/kotlin/oop/Flyweight/SoldierClient.kt

@@ -0,0 +1,13 @@
+package oop.Flyweight
+
+import java.awt.Point


LOL data class Point(val x: Int, val y:Int)

tonilopezmr · 2017-03-30T18:18:00Z

src/main/kotlin/oop/Flyweight/SoldierFactory.kt

+
+class SoldierFactory {
+  companion object {
+    var admiral: Admiral? = null


kotlin? null? seriously? ❌

tonilopezmr · 2017-03-30T18:18:32Z

src/main/kotlin/oop/Flyweight/SoldierFactory.kt

+    var admiral: Admiral? = null
+    var captain: Captain? = null
+
+      fun getSoldier(type: Int): Soldier{


getSoldier(type: Int) lol Do you know what is a sealed class? 👍

Do you know*

Thanks @Cotel at least I can stop crying hard with this

tonilopezmr · 2017-03-30T18:19:54Z

src/main/kotlin/oop/Flyweight/SoldierFactory.kt

+          return captain!!
+        }
+      }
+      throw IllegalArgumentException()


xDDDDD fann1

tonilopezmr

tonilopezmr · 2017-03-30T18:23:51Z

@Cotel Seems ok overall?

Cotel · 2017-03-30T18:46:29Z

Seems okay if you want to treat Kotlin like oldstyle Java, thats why I told him to update his code 🤣

Cotel · 2017-03-31T13:53:19Z

I don't understand anything of this pattern. I've been reading but it is still unclear to me. Can you explain it? I need to know how to review this before I get to it 😵

tonilopezmr · 2017-03-31T14:37:52Z

https://en.wikipedia.org/wiki/Flyweight_pattern

https://sourcemaking.com/design_patterns/flyweight

And this is very good explanation 👍 http://www.arquitecturajava.com/java-flyweight-pattern-rendimiento/

tonilopezmr · 2017-03-31T14:42:42Z

The last one explains what is, in resume, when you have a data structs with duplicates, you remove all your object duplication and share with other objects.

In the @Nhemesy example, he wanted to have a Soldiers that if are the same "type" (same soldier) only create once because are two object with the same values.

tonilopezmr · 2017-04-18T14:48:28Z

@Nhemesy What do you think? you need see the last changes.

We need merge this

tonilopezmr · 2017-04-21T22:48:03Z

@Nhemesy please

tonilopezmr · 2017-04-25T10:47:38Z

Don't forget add Flyweight in README and complete with an example

tonilopezmr · 2017-05-13T16:27:39Z

@tonilopezmr

@Cotel

@Nhemesy

Cotel · 2017-06-14T14:59:55Z

We are back! 💪

Pedro David Rodríguez Sánchez added 2 commits March 30, 2017 10:57

Created flyweight pattern

1d9945d

Added test and support for test

f398035

pedrodaviddev requested review from tonilopezmr, Cotel, Martrout96 and frnlpz March 30, 2017 09:23

pedrodaviddev added the OOP label Mar 30, 2017

Cotel requested review from srgtrujillo, Starkie, ConradoMateu and josegarm March 30, 2017 09:29

Cotel reviewed Mar 30, 2017

View reviewed changes

Cotel previously approved these changes Mar 30, 2017

View reviewed changes

tonilopezmr added the Work In Progress label Mar 30, 2017

tonilopezmr reviewed Mar 30, 2017

View reviewed changes

tonilopezmr requested changes Mar 30, 2017

View reviewed changes

Cotel assigned pedrodaviddev Mar 31, 2017

tonilopezmr added 3 commits March 31, 2017 13:16

Refactor flyweight

b11a283

Improving flyweight with more memory efficency

9aa468f

Created abstraction of Flyweight

a4bfbb9

tonilopezmr removed the Work In Progress label Mar 31, 2017

Cotel changed the base branch from state to master April 24, 2017 09:06

Merge branch 'master' into flyweight

bb1e952

tonilopezmr approved these changes Jun 15, 2017

View reviewed changes

pedrodaviddev removed their assignment Oct 7, 2019

pedrodaviddev dismissed Cotel’s stale review via bb1e952 July 29, 2023 12:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flyweight #28

Flyweight #28

pedrodaviddev commented Mar 30, 2017 •

edited by tonilopezmr

Loading

Cotel Mar 30, 2017

Cotel Mar 30, 2017

Cotel left a comment

tonilopezmr left a comment •

edited

Loading

tonilopezmr Mar 30, 2017

tonilopezmr Mar 30, 2017

tonilopezmr Mar 30, 2017

tonilopezmr Mar 30, 2017

tonilopezmr Mar 30, 2017

tonilopezmr Mar 30, 2017

tonilopezmr Mar 30, 2017

tonilopezmr Mar 30, 2017

tonilopezmr Mar 30, 2017 •

edited

Loading

Cotel Mar 30, 2017

pedrodaviddev Mar 30, 2017

tonilopezmr Mar 30, 2017

tonilopezmr left a comment

tonilopezmr commented Mar 30, 2017

Cotel commented Mar 30, 2017

Cotel commented Mar 31, 2017

tonilopezmr commented Mar 31, 2017

tonilopezmr commented Mar 31, 2017

tonilopezmr commented Apr 18, 2017

tonilopezmr commented Apr 21, 2017

tonilopezmr commented Apr 25, 2017

tonilopezmr commented May 13, 2017 •

edited

Loading

Cotel commented Jun 14, 2017

Flyweight #28

Are you sure you want to change the base?

Flyweight #28

Conversation

pedrodaviddev commented Mar 30, 2017 • edited by tonilopezmr Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cotel left a comment

Choose a reason for hiding this comment

tonilopezmr left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonilopezmr Mar 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tonilopezmr left a comment

Choose a reason for hiding this comment

tonilopezmr commented Mar 30, 2017

Cotel commented Mar 30, 2017

Cotel commented Mar 31, 2017

tonilopezmr commented Mar 31, 2017

tonilopezmr commented Mar 31, 2017

tonilopezmr commented Apr 18, 2017

tonilopezmr commented Apr 21, 2017

tonilopezmr commented Apr 25, 2017

tonilopezmr commented May 13, 2017 • edited Loading

Cotel commented Jun 14, 2017

pedrodaviddev commented Mar 30, 2017 •

edited by tonilopezmr

Loading

tonilopezmr left a comment •

edited

Loading

tonilopezmr Mar 30, 2017 •

edited

Loading

tonilopezmr commented May 13, 2017 •

edited

Loading