Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Endpoint for calculating of Net income, Break-even point, Days sales in inventory ratio, Cash ratio #460

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[Feature]Endpoint for calculating of Net income, Break-even point, Days sales in inventory ratio, Cash ratio #460

wants to merge 16 commits into from

Conversation

suvamita
Copy link
Contributor

No description provided.

@suvamita
Copy link
Contributor Author

@ighoshsubho please review and merge PR

@ighoshsubho
Copy link
Collaborator

@suvamita, there are 3 things I want to mention -

  1. You have made all the requests in the DOCUMENTATION.md and ENDPOINTS.md as GET request please update to POST.
  2. You have made all the endpoints in main as GET, make it POST
  3. You have not used request validations in any of the endpoints. Please do so!

@suvamita
Copy link
Contributor Author

suvamita commented Jul 29, 2023 •
edited
Loading

@ighoshsubho Please review and merge the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suvamita @ighoshsubho