Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Endpoint for calculating of Gross margin ratio, Price-earnings ratio, Earnings per share ratio #484

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[Feature]Endpoint for calculating of Gross margin ratio, Price-earnings ratio, Earnings per share ratio #484

wants to merge 13 commits into from

Conversation

suvamita
Copy link
Contributor

@ighoshsubho Please review and merge the PR.

@ighoshsubho
Copy link
Collaborator

@suvamita there are 2 things that I want to discuss, like -

  • You're doing everything ok but not adding the request validations
  • And it would be better if you make PRs for respective endpoints, that way it will be much more clear and your contributions will be higher too.

@ighoshsubho ighoshsubho mentioned this pull request Aug 4, 2023
Open
@suvamita
Copy link
Contributor Author

suvamita commented Aug 6, 2023

@ighoshsubho Please review and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suvamita @ighoshsubho