Merge pull request #232 from yuanhuas/rss

Tow bugs fixed for soil resistance calculation. [by @zhuo Liu]
CoLM-SYSU · Dec 9, 2023 · b417915 · b417915
2 parents cf41bc0 + 719fee7
commit b417915
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/main/MOD_GroundFluxes.F90 b/main/MOD_GroundFluxes.F90
@@ -224,7 +224,7 @@ subroutine GroundFluxes (zlnd, zsno, hu, ht, hq, hpbl, &
         raih   = rhoair*cpair/rah
 
   ! 08/23/2019, yuan: add soil surface resistance (rss)
-        IF (dqh < 0.) THEN
+        IF (dqh > 0.) THEN
            raiw   = rhoair/raw !dew case. assume no soil resistance
         ELSE
            IF (DEF_RSS_SCHEME .eq. 4) THEN

diff --git a/main/MOD_SoilSurfaceResistance.F90 b/main/MOD_SoilSurfaceResistance.F90
@@ -210,11 +210,11 @@ SUBROUTINE SoilSurfaceResistance (nl_soil,forc_rhoair,hksati,porsl,psi0, &
 #endif
 #ifdef vanGenuchten_Mualem_SOIL_MODEL
    ! TR13, Eqs. (A2), (A7), (A8) and (A10):
-   ! dw = hk*(m-1)/(k*m*(theta_s-theta_r))*S**(-1/m)*(1-S**(1/m))**(-m)
-   ! where k=alpha_vgm, S=(1+(-k*psi0(1))**(n))**(-m), m=m_vgm=1-1/n_vgm
+   ! dw = -hk*(m-1)/(k*m*(theta_s-theta_r))*S**(-1/m)*(1-S**(1/m))**(-m)
+   ! where k=alpha_vgm, S=(1+(-k*smp_node)**(n))**(-m), m=m_vgm=1-1/n_vgm
    m_vgm = 1. - 1./n_vgm(1)
-   S     = (1. + (- alpha_vgm(1)*psi0(1))**(n_vgm(1)))**(-m_vgm)
-   dw    = hk*(m_vgm-1.)/(alpha_vgm(1)*m_vgm*(porsl(1)-theta_r(1))) &
+   S     = (1. + (- alpha_vgm(1)*smp_node)**(n_vgm(1)))**(-m_vgm)
+   dw    = -hk*(m_vgm-1.)/(alpha_vgm(1)*m_vgm*(porsl(1)-theta_r(1))) &
          * S**(-1./m_vgm)*(1.-S**(1./m_vgm))**(-m_vgm)
 #endif
 
@@ -242,7 +242,9 @@ SUBROUTINE SoilSurfaceResistance (nl_soil,forc_rhoair,hksati,porsl,psi0, &
 
    ! calculate rss by TR13
    CASE (3)
+      ! TR13, Eq. (11) and Eq. (12):
       B     = denh2o/(qg*forc_rhoair)
+      ! TR13, Eq. (13):
       rg_1  = 2.0_r8*dg*eps/dz_soisno(1)
       rw_1  = 2.0_r8*dw*B*vol_liq/dz_soisno(1)
       rss_1 = rg_1 + rw_1