Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1) Remove the initialization of tleaf=forc_t of PC for each time; 2) Reset the jdate to sdate and change the jdate to beginning style in spinup repeat; 3) Add annotation for soil resistance and code format adjust. #233

Merged
merged 9 commits into from
Dec 14, 2023
Merged

1) Remove the initialization of tleaf=forc_t of PC for each time; 2) Reset the jdate to sdate and change the jdate to beginning style in spinup repeat; 3) Add annotation for soil resistance and code format adjust. #233

merged 9 commits into from
Dec 14, 2023

Conversation

yuanhuas
Copy link
Contributor 

-fix(MOD_Thermal.F90,MOD_LeafTemperaturePC.F90):
    remove initialization of tleaf_p = forc_t, and set tleaf inside
    MOD_LeafTemperaturePC.F90 for only non-vegetated PFTs.
    A fixed leaf T value of forc_t may lead to a calculation bug in
    PHS subroutine. Rather we use a previous tleaf_p.

-adj(MOD_LeafTemperaturePC.F90,MOD_Thermal.F90):
    code format adjust.

-fix(CoLM.F90):
    Reset the jdate to sdate and change the jdate to beginning style 
    in spinup repeat. [by @tungwz]

-add(MOD_SoilSurfaceResistance.F90):
    add annotation for soil resistance subroutine.

-adj(MOD_Urban_BEM.F90,MOD_SoilSurfaceResistance.F90):
    code format adjust.

yuanhuas and others added 9 commits December 10, 2023 10:40
@yuanhuas
Code format adjust for MOD_GroundFluxes.F90.
03d7871
@yuanhuas
Merge branch 'master' of github.com:yuanhuas/CoLM202X
04b2f89
@yuanhuas
Remove the initialization of tleaf=forc_t of PC for each time.
77e083c 
-fix(MOD_Thermal.F90,MOD_LeafTemperaturePC.F90):
    remove initialization of tleaf_p = forc_t, and set tleaf inside
    MOD_LeafTemperaturePC.F90 for only non-vegetated PFTs.
    A fixed leaf T value of forc_t may lead to a calculation bug in
    PHS subroutine. Rather we use a previous tleaf_p.

-adj(MOD_LeafTemperaturePC.F90):
    code format adjust.
@tungwz
Merge pull request #49 from yuanhuas/master
719bd52 
PR1211
@tungwz
-fix(CoLM.F90) Reset the jdate to sdate and change the jdate to begin…
b6695d1 
…ning style in spinup repeat
@yuanhuas
Merge pull request #65 from tungwz/master
88fd5c4 
Reset the jdate to sdate and change the jdate to beginning style in spinup repeat
@yuanhuas
Add annotation for soil resistance and code format adjust.
f6638f3 
-add(MOD_SoilSurfaceResistance.F90):
    add annotation for soil resistance subroutine.

-adj(MOD_Urban_BEM.F90,MOD_SoilSurfaceResistance.F90):
    code format adjust.
@yuanhuas
Merge branch 'master' of github.com:yuanhuas/CoLM202X
fa0c5dd
@yuanhuas
Code format adjust for MOD_Thermal.F90.
e1dbd05
@CoLM-SYSU CoLM-SYSU merged commit 1b7f3d4 into CoLM-SYSU:master Dec 14, 2023
24 checks passed
xuxh1 pushed a commit to xuxh1/CoLM202X that referenced this pull request Oct 26, 2024
@CoLM-SYSU
Merge pull request CoLM-SYSU#233 from yuanhuas/master
8879570 
1) Remove the initialization of tleaf=forc_t of PC for each time; 2) Reset the jdate to sdate and change the jdate to beginning style in spinup repeat; 3) Add annotation for soil resistance and code format adjust.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuanhuas @CoLM-SYSU @tungwz