share, mksrfdata, mkinidata, main/HYDRO, main/DA and postprocess code… #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leelew
reviewed
Jan 25, 2024
main/DA/MOD_DataAssimilation.F90
Outdated
|
|
||
| INTEGER, INTENT(in) :: idate(3) | ||
| REAL(r8), INTENT(in) :: deltim | ||
| integer, intent(in) :: idate(3) |
There was a problem hiding this comment.
Lines 26-27: Please delete three space.
There was a problem hiding this comment.
Add some descriptions of DA module?
| @@ -75,7 +75,7 @@ END SUBROUTINE allocate_1D_HydroFluxes | |||
|
|
|||
| SUBROUTINE deallocate_1D_HydroFluxes | |||
|
|
|||
| IMPLICIT NONE | |||
| IMPLICIT NONE | |||
| integer :: s_year ! starting date for run in year | ||
| integer :: s_month ! starting date for run in month | ||
| integer :: s_day ! starting date for run in day | ||
| integer :: s_julian ! starting date for run in julian day | ||
| integer :: s_seconds ! starting time of day for run in seconds | ||
| integer :: idate(3) ! starting date | ||
| INTEGER :: lc_year ! land cover year | ||
| integer :: lc_year ! land cover year | ||
| logical :: greenwich ! true: greenwich time, false: local time | ||
|
|
||
| integer*8 :: start_time, end_time, c_per_sec, time_used | ||
|
|
There was a problem hiding this comment.
Did the calculation processes in PROGRAM should intend three space?
mkinidata/CoLMINI.F90
Outdated
| @@ -112,20 +113,20 @@ PROGRAM CoLMINI | |||
| CAll Init_LC_Const | |||
There was a problem hiding this comment.
Lines 113-114: CAll -> CALL
share/MOD_NetCDFVectorPar.F90
Outdated
| filename, dataname, dim1name, ndim1, & | ||
| vecname, pixelset, wdata, compress_level) | ||
|
|
||
| IMPLICIT NONE |
share/MOD_NetCDFVectorPar.F90
Outdated
| filename, dataname, dim1name, ndim1, dim2name, ndim2, & | ||
| vecname, pixelset, wdata, compress_level) | ||
|
|
||
| IMPLICIT NONE |
share/MOD_NetCDFVectorPar.F90
Outdated
| filename, dataname, dim1name, ndim1, dim2name, ndim2, dim3name, ndim3, & | ||
| vecname, pixelset, wdata, compress_level) | ||
|
|
||
| IMPLICIT NONE |
| END TYPE timestamp | ||
| type :: timestamp | ||
| integer :: year, day, sec | ||
| END type timestamp | ||
|
|
||
| INTERFACE ASSIGNMENT (=) |
| @@ -59,22 +59,22 @@ MODULE MOD_TimeManager | |||
| MODULE procedure calendarday_stamp | |||
| END INTERFACE | |||
xuxh1
pushed a commit
to xuxh1/CoLM202X
that referenced
this pull request
Oct 26, 2024
share, mksrfdata, mkinidata, main/HYDRO, main/DA and postprocess code…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… adjustment and optimization