Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1) Code indent and fout case adjustmentfor Urban module; 2) Code indent for LULCC and some corrections for URBAN and main. #246

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

yuanhuas
Copy link
Contributor

-adj(URBAN/*.F90):
    code indent and font case adjustment for URBAN/*.F90 files.

-adj(LULCC/*.F90,URBAN/*.F90):
    code indent for LULCC and some fix for URBAN and CoLM.F90.

-adj(URBAN/*.F90):
    code indent and font case adjustment for URBAN/*.F90 files.
-adj(LULCC/*.F90,URBAN/*.F90):
    code indent for LULCC and some fix for URBAN and CoLM.F90.
Merge pull request CoLM-SYSU#238 from yuanhuas/master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code indent: Line 435-606 @yuanhuas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm whether the model need stop running if imbalance happens in each balance-check part. @yuanhuas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need a short description for this file or parts of subroutines/functions. @yuanhuas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm whether the model need stop running when energy imbalance happens or olrg < 0. @yuanhuas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code indent: Line 77-78, 144-145 @yuanhuas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all done.

@CoLM-SYSU CoLM-SYSU merged commit 1b37767 into CoLM-SYSU:master Jan 26, 2024
24 checks passed
yuanhuas added a commit to yuanhuas/CoLM202X that referenced this pull request Jan 28, 2024
CoLM-SYSU added a commit that referenced this pull request Jan 29, 2024
Code format correction for PR #246, #238, and some others found.
xuxh1 pushed a commit to xuxh1/CoLM202X that referenced this pull request Oct 26, 2024
1) Code indent and fout case adjustmentfor Urban module; 2) Code indent for LULCC and some corrections for URBAN and main.
xuxh1 pushed a commit to xuxh1/CoLM202X that referenced this pull request Oct 26, 2024
xuxh1 pushed a commit to xuxh1/CoLM202X that referenced this pull request Oct 26, 2024
Code format correction for PR CoLM-SYSU#246, CoLM-SYSU#238, and some others found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants