-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1) Code indent and fout case adjustmentfor Urban module; 2) Code indent for LULCC and some corrections for URBAN and main. #246
Conversation
yuanhuas
commented
Jan 25, 2024
-adj(URBAN/*.F90): code indent and font case adjustment for URBAN/*.F90 files.
-adj(LULCC/*.F90,URBAN/*.F90): code indent for LULCC and some fix for URBAN and CoLM.F90.
Merge pull request CoLM-SYSU#238 from yuanhuas/master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code indent: Line 435-606 @yuanhuas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm whether the model need stop running if imbalance happens in each balance-check part. @yuanhuas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need a short description for this file or parts of subroutines/functions. @yuanhuas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm whether the model need stop running when energy imbalance happens or olrg < 0. @yuanhuas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code indent: Line 77-78, 144-145 @yuanhuas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all done.
1) Code indent and fout case adjustmentfor Urban module; 2) Code indent for LULCC and some corrections for URBAN and main.
Code format correction for PR CoLM-SYSU#246, CoLM-SYSU#238, and some others found.