Bunch of patches + hopper fix #352

crafter23456 · 2022-02-19T19:33:56Z

Fixes a huge hopper exploit, caused by #76. @Outfluencer probably you have a better fix than removing it.
If the world was saves or with /save-all, the hopper got cleared. So I removed that function and now its working like expected.

Some commits has incorrectly the name SportPaper. But in readme its better.

Fixes/Adds

See readme.

How has this been tested?

Hopper bug got tested. Other patches only with building without errors and running in the MC world with no console errors.

Checklist:

[Im not good so no] I have reviewed my code thoroughly
I have tested my code
My changes generate no new warnings

…nkLoader & chunkProvider

…ng EntityDamageEvent

ghost · 2022-02-19T19:37:54Z

You're combining patches from others projects without testing them properly (From your desc, you only tested the hopper bug), why?

crafter23456 · 2022-02-19T19:42:53Z

Yeah, the hopper bug was my original intention to make that PR because that was reported a bunch of times on the Discord. But then I added a few more things. For the lava change I placed lava and it flowed. The chunks were also loading normally so I expected the chunk things worked. If somethings didnt get called I didnt test because I didnt write a plugin to test it :D

ghost

Looks good! Can you also check if this fixes #202 and if #75 occurs?

NachoSpigot-Server/pom.xml

NachoSpigot-Server/src/main/java/net/minecraft/server/Entity.java

NachoSpigot-Server/src/main/java/net/minecraft/server/RegionFileCache.java

NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/CraftServer.java

NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/entity/CraftEntity.java

NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java

crafter23456 · 2022-02-19T20:53:30Z

Looks good! Can you also check if this fixes #202 and if #75 occurs?

I coudnt reproduce #75. Same on normal nacho.
The whole hopper thing #202 is weird. With normal nacho + my PR the lowest and the highest chest fills. so 50% highest and 50% lowest. Beside of that it takes 4 items, than 2 items like in config.
So my PR only fix that the items disappear, but isnt related to these bugs. I still could have a look at it.
EDIT: I wasnt able

Sculas · 2022-02-20T16:07:43Z

I won't merge this yet since some things aren't sure according to reviews and comments.
In the case I forget, please ping me when this PR is fully ready to merge (and was tested) :)

…/CraftEntity.java Co-authored-by: Elier <[email protected]>

…erver.java Co-authored-by: Elier <[email protected]>

Co-authored-by: Elier <[email protected]>

…leCache.java Co-authored-by: Elier <[email protected]>

crafter23456 · 2022-02-24T21:09:02Z

I won't merge this yet since some things aren't sure according to reviews and comments. In the case I forget, please ping me when this PR is fully ready to merge (and was tested) :)

So all hints from elier got merged. so only testing even if i dont see anything at first look :D

ghost · 2022-02-24T21:22:43Z

So all hints from elier got merged. so only testing even if i dont see anything at first look :D

I’m going to review this again later since there’s more changes

ghost

Mostly just formatting issues

NachoSpigot-Server/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java

NachoSpigot-Server/src/main/java/net/minecraft/server/Chunk.java

NachoSpigot-Server/src/main/java/net/minecraft/server/ChunkRegionLoader.java

NachoSpigot-Server/src/main/java/net/minecraft/server/ChunkSection.java

NachoSpigot-Server/src/main/java/net/minecraft/server/WorldServer.java

NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/CraftWorld.java

NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java

…tion.java Co-authored-by: Elier <[email protected]>

Co-authored-by: Elier <[email protected]>

…ver.java Co-authored-by: Elier <[email protected]>

…orld.java Co-authored-by: Elier <[email protected]>

…/CraftPlayer.java Co-authored-by: Elier <[email protected]>

…WorldConfig.java Co-authored-by: Elier <[email protected]>

…ayer.java Co-authored-by: Elier <[email protected]>

…tServer.java Co-authored-by: Elier <[email protected]>

…leCache.java Co-authored-by: Elier <[email protected]>

Co-authored-by: Elier <[email protected]>

…leCache.java Co-authored-by: Elier <[email protected]>

crafter23456 · 2022-02-25T08:46:02Z

All got accepted

Sculas · 2022-02-26T22:14:38Z

Thanks to all the participants in this PR for helping out!

crafter23456 added 10 commits February 19, 2022 16:55

undo CobbleSword#74

0830961

add SportPaper CobbleSword#207 Block#toLegacyData optimisation

65351cb

add SportPaper CobbleSword#206 Remove the world before nullifying chu…

d9a8216

…nkLoader & chunkProvider

add SportPaper CobbleSword#204 dont divide d14 by 0

af7c34e

add SportPaper CobbleSword#220 Use EnumMap in CraftPlayer#playEffect()

906515f

add SportPaper CobbleSword#218 Update entity head yaw on teleport

67ba4c1

add SportPaper CobbleSword#130 fix CraftLivingEntity#damage not calli…

1ee07be

…ng EntityDamageEvent

add Migot CobbleSword#36 Check for lava only once per tick

fb58656

add optimize region cache - paper 1.13 backport

8530f71

update readme

fa62baf

ghost suggested changes Feb 19, 2022

View reviewed changes

crafter23456 added 6 commits February 20, 2022 15:17

backport parts of light queue changes from 1.13

b388597

Paper CobbleSword#178 Disable Vanilla Chunk GC in favor of Bukkits

0a001e0

Paper CobbleSword#176 Auto fix bad Y levels on player login

6e842aa

Paper CobbleSword#172 Incremental Auto Saving

ead58d0

Paper Chunk registration fixes & Fix infinite loop when saving chunks

0d70a5a

Paper CobbleSword#163 MC-80966 - Always send chunk sections

ea26cc5

Paper Fix hopper suck in patch bug

25c8d15

crafter23456 force-pushed the hopper-patch branch from 5ecf91d to 25c8d15 Compare February 20, 2022 17:48

crafter23456 and others added 7 commits February 20, 2022 18:53

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/entity…

f639d78

…/CraftEntity.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/CraftS…

400bd69

…erver.java Co-authored-by: Elier <[email protected]>

third time to add dictionary.java...

8b91923

im very dump

8a12b67

forth time to fix that... shall have more sleep

4b5d317

Update NachoSpigot-Server/src/main/java/net/minecraft/server/Entity.java

78d7d8d

Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/net/minecraft/server/Entity.java

97b0d13

Co-authored-by: Elier <[email protected]>

crafter23456 and others added 3 commits February 24, 2022 21:01

Update NachoSpigot-Server/src/main/java/net/minecraft/server/RegionFi…

e95bf40

…leCache.java Co-authored-by: Elier <[email protected]>

revert kigpaper optimize damage source

4740db6

get away because of revert

8cf13c9

ghost approved these changes Feb 24, 2022

View reviewed changes

crafter23456 and others added 15 commits February 25, 2022 07:52

Update NachoSpigot-Server/src/main/java/net/minecraft/server/ChunkSec…

a8a3c67

…tion.java Co-authored-by: Elier <[email protected]>

Fix spaces

3023a79

Co-authored-by: Elier <[email protected]>

Fix spaces

0d4f95d

Co-authored-by: Elier <[email protected]>

Fix spaces

72ba7b8

Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/net/minecraft/server/WorldSer…

d49d5b7

…ver.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/CraftW…

26b3c92

…orld.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/entity…

5fe0231

…/CraftPlayer.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/entity…

ed39593

…/CraftPlayer.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/entity…

853dbc1

…/CraftPlayer.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/com/destroystokyo/paper/Paper…

a64aef0

…WorldConfig.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/net/minecraft/server/EntityPl…

09bfcc0

…ayer.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/net/minecraft/server/Minecraf…

60daec5

…tServer.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/net/minecraft/server/RegionFi…

82562a1

…leCache.java Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/net/minecraft/server/World.java

57ed16f

Co-authored-by: Elier <[email protected]>

Update NachoSpigot-Server/src/main/java/net/minecraft/server/RegionFi…

fc32a46

…leCache.java Co-authored-by: Elier <[email protected]>

Sculas merged commit ec731d5 into CobbleSword:master Feb 26, 2022

crafter23456 deleted the hopper-patch branch March 6, 2022 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bunch of patches + hopper fix #352

Bunch of patches + hopper fix #352

crafter23456 commented Feb 19, 2022

ghost commented Feb 19, 2022

crafter23456 commented Feb 19, 2022 •

edited

Loading

ghost left a comment

crafter23456 commented Feb 19, 2022 •

edited

Loading

Sculas commented Feb 20, 2022

crafter23456 commented Feb 24, 2022

ghost commented Feb 24, 2022

ghost left a comment

crafter23456 commented Feb 25, 2022

Sculas commented Feb 26, 2022

Bunch of patches + hopper fix #352

Bunch of patches + hopper fix #352

Conversation

crafter23456 commented Feb 19, 2022

Fixes/Adds

How has this been tested?

Checklist:

ghost commented Feb 19, 2022

crafter23456 commented Feb 19, 2022 • edited Loading

ghost left a comment

Choose a reason for hiding this comment

crafter23456 commented Feb 19, 2022 • edited Loading

Sculas commented Feb 20, 2022

crafter23456 commented Feb 24, 2022

ghost commented Feb 24, 2022

ghost left a comment

Choose a reason for hiding this comment

crafter23456 commented Feb 25, 2022

Sculas commented Feb 26, 2022

crafter23456 commented Feb 19, 2022 •

edited

Loading

crafter23456 commented Feb 19, 2022 •

edited

Loading