Prefix rangeOfTextLists method to avoid accidental call by UIKit #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1289, this
NSAttributedStringcategory method is unexpectedly being called by internal TextKit logic, perhaps checking for method availability rather than platform. Since categories cannot be un-defined by consumers ofDTCoreText, there is no workaround for this situation.This PR adds a prefix to avoid this naming collision. Ideally, we could define the old name as deprecated/renamed to indicate to the consumer of the library that this change has been made, but that is not possible as any inclusion of a method with this name will cause the problem.