Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHE-129] Add Edit Functionality To Posts #141

Conversation

brok3turtl3
Copy link
Contributor

@brok3turtl3 brok3turtl3 commented Jun 12, 2024

Description

As part of the CHE-110 story, Forums Improvements, this PR adds edit functionality to posts that the user made.

  • Future tickets to move some of the display logic to individual components as well as migration to redux state to follow.

Jira Task

CHE-129

Testing Instructions

  1. Ensure branches are up to date and spin up dev environment.
  2. Navigate to Forums and confirm that the only posts you can edit correspond to the user you are logged in under.
  3. Select one of your user's posts and use the edit feature.
  4. Confirm edits and updates to posts are immediate.

Checklist

All Team Members

  • I added a descriptive title to this PR.
  • I filled out the Description, Jira Task, and Testing Instructions sections above.
  • I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc.
  • I ran npm run docker-test in my local environment to check that this PR passes all unit tests.
  • I did a quick check to make sure my code changes follow the recommended style guide.

Additional Notes, Images, etc.

N/A

@brok3turtl3 brok3turtl3 added the enhancement New feature or request label Jun 12, 2024
@brok3turtl3 brok3turtl3 self-assigned this Jun 12, 2024
Comment on lines 105 to 107
<h3 className="font-bold text-2xl">Replies</h3>
{posts.map((post) => (
<div key={post._id} className="mb-4">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently setup to enable users to edit replies they've posted. Is this the goal or are we trying to enable editing of the actual posts themselves?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mnelson98 - This PR should only allow users to edit the replies they have posted to threads (topics). There is a subsequent PR up that will allow them to edit the initial thread post itself.

@brok3turtl3 brok3turtl3 merged commit bf5aac9 into CHE-110/story/Forums-Improvements Jun 19, 2024
1 check passed
@brok3turtl3 brok3turtl3 deleted the CHE-129/subtask/Add-Edit-Functionality-To-Posts branch June 19, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants