Rename "Delimeter" to Delimiter #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PrimeJoker
commented
Sep 7, 2023
•
PrimeJoker
commented
- fix the build error "Delimiter" does not exist in the current context. Amend to MudCsvMapper - Delimter to "Delimiter" and reuse it when creating output data file #274 created.
|
This seems like it is a simple fix. |
|
@mckaragoz this looks like it can be merged. It fixes a typo. |
Yes it's done, but it's a breaking change. And not obsoleted the old parameter, directly removed. |
|
When do you think it can be pushed live? |
If you can obsolete the old parameter instead of completely remove we can merge it today. But currently it's a direct breaking change, users will have errors after update the package, so we need to wait next major release |
|
@mckaragoz I have reinstated the original parameter name to make it easier to merge pull request. |
|
Hi, its now time to fix this typo, could you prepare a new fresh PR? |
PrimeJoker
added a commit
to PrimeJoker/CodeBeam.MudBlazor.Extensions
that referenced
this pull request
May 4, 2024
- Use the same Delimeter selected to output data file. CodeBeamOrg#275
mckaragoz
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.