Change test option to boolean
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user needs to choose whether tests are enabled or not while
configuring the build, or fallback to the provided default. We can't
divine their thoughts; there's no programmatic way to determine a valid
choice, unlike with dependency-detection via pkg-config or some other
mechanism.
The `required` parameter of `find_program()` defaults to true. Eliminate
its specification for test programs, as the `find_program()` invocations
are already gated on the result of `get_option('tests')`.
Signed-off-by: Andrew Jeffery <[email protected]>
There's no need for the configuration file if we're not going to run the tests. Signed-off-by: Andrew Jeffery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether tests should be enabled isn't something that should be auto-detected. Switch the option from
featuretoboolean, and cleanup the meson.build file.The bitbake recipe should be updated to specify the following when bumped: