-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for the utils available. #10
base: main
Are you sure you want to change the base?
Conversation
… not set in the environment variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @esirK
Quick review:
I'm all for unit tests but I'm more interested in integration tests & I believe those give us more bang for the buck. So rather than testing if GoogleSheetHelper
has credentials set & what format those credentials are in, a more valuable test is can GoogleSheetHelper
connect when given valid credentials? etc.
PS: If a PR is under draft @esirK, the assumption is you're still working on it privately & you don't need reviews from the team just yet 😎 . |
I had talked to @ascii-dev on writing unit tests but after writing them, I wanted to discuss with the rest of the team on whether we should do integration tests instead of just unit tests that's why I made the PR a draft. |
Description
Adds unittests for both gsheet helper and twitter stream listener.
Type of change
Screenshots
Checklist: