Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft/Water Page #274

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

ft/Water Page #274

wants to merge 7 commits into from

Conversation

kelvinkipruto
Copy link
Contributor

Description

This PR Updates water page with correct content

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vercel
Copy link

vercel bot commented Dec 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sensors-africa ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 8:48AM (UTC)

@kelvinkipruto
Copy link
Contributor Author

@kilemensi I have started on the water page and reused most of the existing components. Is this the right approach before I move to the rest of the pages?

@kilemensi
Copy link
Member

kilemensi commented Dec 2, 2022

@kilemensi I have started on the water page and reused most of the existing components. Is this the right approach before I move to the rest of the pages?

I believe so @kelvinkipruto ... haven't thought much about this yet. I thought we'll first fix issues in air pages before switching to something else. e.g. CodeForAfrica/ui#263, adding more cities mentioned in the document, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants