Proposal: Opening/Closing Mechanism for Zip Files #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael5601
force-pushed
the
ZipFileImplementation
branch
3 times, most recently
from
0a207a1
to
2707f57
Compare
CodeLtDave
force-pushed
the
ZipFileImplementation
branch
from
81791c0
to
48a64d2
Compare
Michael5601
force-pushed
the
ZipFileImplementation
branch
8 times, most recently
from
d17a1e9
to
ec9cb04
Compare
Michael5601
force-pushed
the
master
branch
3 times, most recently
from
a1ed640
to
0196f11
Compare
Michael5601
force-pushed
the
ZipFileImplementation
branch
13 times, most recently
from
05ff57f
to
78621cc
Compare
Michael5601
force-pushed
the
ZipFileImplementation
branch
2 times, most recently
from
edcdc9b
to
7350ba7
Compare
…with nio open check
temporary workaround for CloseTest#testCloseZipFileWithZipFileUnderneath
This change fixes various problems regarding ClosedZipFileSystemException, NoZipFileSystemFoundException and ZipFileSystemAlreadyExistsException
The default value of create is false
All ZIP-based zip files like zip, jar and war can be put on the classpath of the project. To avoid UI bugs, only zip files can be opened that are not added to the project's classpath. This commit introduces a check for the classpath.
This reverts commit cc797ed.
This reverts commit 9e3d212.
to make sure that clients like JDT do not have a behaviour change or even errors the code for opening zip files is encapsulated in a IWorkspaceRunnable. This allows opening zip files on the class path.
CodeLtDave
force-pushed
the
ZipFileImplementation
branch
from
b155e9d
to
ba2cef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: Opening/Closing Mechanism for Zip Files
Background
The Eclipse IDE has no built in functionality to open Zip Files and read or manipulate their content. Because of this, other operations like searching inside of Zip Files or comparing two Zip Files were also not possible.
Goal:
This pull request introduces a mechanism for handling Zip Files within the Eclipse workspace, enhancing the functionality to read and write Zip files. The primary goal is to provide a seamless experience for developers working with zip archives directly within Eclipse.
Description:
Zip files must be opened manually within the workspace by using the new command "Open Zip File" in the menu when right clicking the zip file. It is also possible to open nested zip files.
Zip Files are opened by replacing the file in the workspace with a linked folder that reads and writes the Zip File in the file system. By closing the Zip FIle, the linked folder will be deleted and the file can be seen in the workspace again.
Please note that only ZIP Archives are supported in this current implementation. Other archive types can be added in future improvements. Also linked Zip Files can not be opened with this implementation because the Zip File must be local.
An additional PR for the repository eclipse.platform.ui that grants access to the open/close mechanism for zip files over UI can be found in the following:
#(insert number of PR)