NW5 Manchester - Doris Siu - SQL - Week 1 #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous PR tracked node_modules even I have included .gitignore. I found out that I have forked the repo which the node_modules was commited, caused the issue. Therefore, I do the work from scratch to make sure the forked repo I work on is removed with node_modules.
Craques
reviewed
Feb 9, 2023
| }); | ||
|
|
||
| const handleChange = (e) => { | ||
| setInput({ ...input, [e.target.name]: e.target.value }); |
There was a problem hiding this comment.
Looks good, just a minor suggestion, would it be possible to destructure name and value from e.target as variables?
Craques
reviewed
Feb 9, 2023
| addVideo(input); | ||
| }; | ||
|
|
||
| function uuidv4() { |
There was a problem hiding this comment.
maybe you can use the uuid library for this unless there is a valid reason to build your own random character generator, otherwise this looks great, good stuff
https://www.npmjs.com/package/uuid if you are using npm
https://yarnpkg.com/package/uuidv4 uf you are using yarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.