London 10 | Elena Barker | Full-Stack-Project | Level-300 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdated get endpoint in server
| import ThumbDown from "@material-ui/icons/ThumbDown"; | ||
|
|
||
| const CountVotes = () => { | ||
| const [likeCount, setLikeCount] = useState(0); |
There was a problem hiding this comment.
These three pieces of state all only ever change together, which means they maybe could be collapsed into one piece of state (maybe with values "like", "neutral", and "dislike") - what do you think?
| }); | ||
|
|
||
| // GET "/{id}" | ||
| app.get("/:id", (req, res) => { |
There was a problem hiding this comment.
It looks like this endpoint and the /videos/:id endpoint didn't get updated to use the database yet?
server/server.js
Outdated
| const videoId = parseInt(request.params.id); | ||
| const singleVideo = videos.find((singleVideo) => singleVideo.id === videoId); | ||
| if (singleVideo) { | ||
| videos.splice(singleVideo, 1); |
There was a problem hiding this comment.
Splice takes as its first argument an index not a value - are you sure this code works?
I updated the server by changing the path for the deployed backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.