London-10 | Iryna Lypnyk | Full Stack Assessment | Level 300 #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrynaLypnyk
changed the title
| try { | ||
| fetch(`${API_URL}/${id}`, { | ||
| method: "DELETE", // или 'PUT' | ||
| body: JSON.stringify({id}), // данные могут быть 'строкой' или {объектом}! |
There was a problem hiding this comment.
You generally don't need to include the same data in both the path and the body - you can probably just put it in one place or the other, as long as the server knows where it's going to read it from :)
| } | ||
| }; | ||
|
|
||
| const handleOrderChange = (value) => { |
There was a problem hiding this comment.
I'm not sure what value this function is adding over just calling setOrder directly?
| const {video: {id, title, url, rating: videoRating, timestamp}, handleDeleteVideo} = props; | ||
| const [rating, setRating] = React.useState(videoRating); | ||
|
|
||
| const videoId = url.split("v=")[1].substring(0, 11); |
There was a problem hiding this comment.
What's special about the first 11 characters? It may be worth including a comment describing why you're stripping off the end, and why that's the right place to stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.