Support doctrine/orm v3 + doctrine/dbal v4 #78
Conversation
| @@ -568,6 +565,10 @@ public function testOneToManyRecursiveEntityCreation() | |||
|
|
|||
| public function testHaveFakeRepository() | |||
| { | |||
| if (version_compare(InstalledVersions::getVersion('doctrine/orm'), '3', '>=')) { | |||
There was a problem hiding this comment.
EntityManager::$repositoryFactory was made readonly in ORM v3.
W0rma
changed the title
src/Codeception/Module/Doctrine2.php
Outdated
| // Do not call $reflectedRepositoryFactory->isReadOnly() directly because | ||
| // phpstan will complain about a non-existing method when using PHP 8.0. | ||
| // isReadOnly() is available as-of PHP 8.1. | ||
| if ($reflectedRepositoryFactory->hasMethod('isReadOnly') && $reflectedRepositoryFactory->getMethod('isReadOnly')->invoke(null)) { |
There was a problem hiding this comment.
EntityManager::$repositoryFactory was made readonly in ORM v3.
As a consequence haveFakeRepository() does not work for ORM v3 anymore.
|
@Naktibalda @TavoNiievez Please let me know if I can help to move this PR forward. It would be great to have support for DBAL v4 and ORM v3. I have tested the changes in two of my projects and they seem to work fine. The PRs #73 and #76 can be closed as soon as this PR has been merged. |
|
@W0rma For my part, looking very superficially at the changes. It seems to me that we should not replace annotations by attributes in all tests. Mapping with annotations is still valid so we should have at least 1 test with them to verify that they still work. Then, we don't need PHP 8.0 support anymore, since that version is no longer officially supported. So, instead of you creating compatibility logic for PHP 8.0 simply remove its support from composer.json and main.yml. Finally, I would not want this PR to be released in this repository if it is merged. @ThomasLandauer already talked several times about this and each of those times I agreed with him regarding 'does it make sense to have a module that supports Doctrine 3 but is called module-doctrine2?'. New repositories had to be created for other modules to remove the version number from their name and the same should happen here. cc. @Naktibalda |
|
Indeed, since Doctrine ORM 3 is out now, renaming the module from "Doctrine2" to "Doctrine" is more urgent now. Here's the issue you're referring to: Codeception/module-doctrine#27 |
…m:3 because the property became readonly
…/uuid which do not block doctrine/dbal:4
…eConnection method
Done. Tests now use attributes with ORM v3 and annotations with ORM v2.
Done. PHP 8.0 has been dropped.
Personally, I don't see a problem with this repository supporting ORM v2 and ORM v3. According to Codeception/Codeception#6733 @Naktibalda does not plan to make bigger contributions anymore. I really hope that there is someone who can care about making this repository compatible with ORM v3. |
|
@W0rma do you want to be maintainer of this repository? 😅 |
|
A repository has been created that does not include the version number in its name: I have moved this PR to that repository and already merged it: I will close the PR to avoid duplicity, it only remains to rename the Doctrine2 class to Doctrine and update the references in the documentation to the new repository, when this is done version 3.1.0 of |
closes Codeception/module-doctrine#1
closes Codeception/module-doctrine#4
I cherry-picked the commits from #73 (fixes a deprecation when using ORM v2) and #76 (runs tests with PHP 8.2 and 8.3).