Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move translation option to action tab #1019

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Dec 9, 2024

Summary

This moves the translation settings from Import Metabox to the Translation Action of the Title/Content tag.

Will affect visual aspect of the product

YES

Screenshots

Screenshot 2024-12-10 at 3 54 40 AM

Test instructions

  • This PR requires thorough testing.
  • First, make sure translations work properly with the new options.
  • Second, we need to confirm backward compatibility testing in two ways:
  • If you have set translation settings before updating to this, they should continue to work as normal.
  • If you have set translation settings before updating to this, you should be easily able to edit them from the action bar and it should inherit the language that was previously set.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/784.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
s0undt3ch Pedro Algarvio
@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 9, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 9, 2024
@pirate-bot
Copy link
Contributor

Plugin build for cf7d22a is ready 🛎️!

Copy link
Contributor

@girishpanchal30 girishpanchal30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@selul selul merged commit bedd1dd into development Dec 12, 2024
12 checks passed
@selul selul deleted the feat/translation-action branch December 12, 2024 15:02
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants