Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add review modal #1036

Merged
merged 7 commits into from
Dec 20, 2024
Merged

feat: add review modal #1036

merged 7 commits into from
Dec 20, 2024

Conversation

HardeepAsrani
Copy link
Member

Summary

It adds a review request to Imports page when all of the following conditions are true:

  • The plugin has been installed for at least a week. It is saved in feedzy_rss_feeds_install option.
  • At least one import job has imported at least 100 posts.

Will affect visual aspect of the product

YES

Screenshots

Screenshot 2024-12-18 at 7 46 56 PM

Test instructions

  • Once all the described conditions are true, confirm the modal appears in the Imports page.
  • If any of that is not true, it shouldn't appear.
  • Make sure it goes away once you dismiss.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/771.

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 18, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 18, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 18, 2024 •
edited
Loading

Plugin build for 956f2e9 is ready 🛎️!

Soare-Robert-Daniel
Soare-Robert-Daniel requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments regarding how to handle the translation.

@HardeepAsrani HardeepAsrani changed the title Fix/issue 771 feat: add review modal Dec 19, 2024
@selul selul merged commit f9d822a into development Dec 20, 2024
8 checks passed
@selul selul deleted the fix/issue-771 branch December 20, 2024 10:50
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soare-Robert-Daniel Soare-Robert-Daniel Soare-Robert-Daniel approved these changes

Assignees
No one assigned
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HardeepAsrani @pirate-bot @Soare-Robert-Daniel @selul