Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature usage observer #846

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Add feature usage observer #846

merged 7 commits into from
Dec 20, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 18, 2023

Summary

  • Enabled the SDK telemetry for this product.
  • The plugin settings are tracked via the Form submit event.
  • Added block options tracking.

Also added the toggle for Telemetry since WP does not want telemetry by default.

image

Testing

  • Enable Telemetry in the settings.
  • Check if something is broken.
  • Post the test instance URL so we can check in the metabase for the saved events.

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 18, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 18, 2023 15:34
@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 18, 2023

Plugin build for 858d857 is ready 🛎️!

Copy link
Contributor

@GrigoreMihai GrigoreMihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment mentioned everything looks good.

includes/admin/feedzy-rss-feeds-admin.php Outdated Show resolved Hide resolved
@vytisbulkevicius
Copy link
Contributor

vytisbulkevicius commented Dec 19, 2023

@Soare-Robert-Daniel, do you think we can integrate the question about agreeing to enable Telemetry into the onboarding steps of Feedzy also? (and make it enabled if they agree)

I think it's quite a low chance for users to go in there in Settings and enabling on purpose it without us pointing to it in any way/asking them.

@Soare-Robert-Daniel
Copy link
Contributor Author

@Soare-Robert-Daniel, do you think we can integrate the question about agreeing to enable Telemetry into the onboarding steps of Feedzy also? (and make it enabled if they agree)

@vytisbulkevicius, We can do something like this for Import Post Onboarding.

image

@Soare-Robert-Daniel
Copy link
Contributor Author

@vytisbulkevicius I added it like this:

image

@vytisbulkevicius
Copy link
Contributor

Perfect, thanks @Soare-Robert-Daniel

@vytisbulkevicius
Copy link
Contributor

@preda-bogdan, please give a look at this one if you have any suggestions, looking to include it in the release today. Thanks! 🙏

@vytisbulkevicius vytisbulkevicius merged commit 5d483a6 into development Dec 20, 2023
8 checks passed
@vytisbulkevicius vytisbulkevicius deleted the feat/telemetry branch December 20, 2023 09:29
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants