Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag parsing for feed source generated by endpoint #903

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Mar 12, 2024

Closes #899

Summary

When full_content magic tag is present, the endpoint will create a single feed with all the data. The feed is enhanced with custom tags under feedzy tag namespace.

With the changes from https://github.com/Codeinwp/feedzy-full-post/pull/89. The item feed looks like this:

<entry>
	<guid>https://community.511tactical.com/5-11-announces-the-return-of-abr-academy-classes-for-2023-in-collaboration-with-uscca-copy/</guid>
	<link href="https://www.511tactical.com/community/5-11-announces-the-return-of-abr-academy-classes-for-2023-in-collaboration-with-uscca-2/"/>
	<title><![CDATA[5.11 Tactical to Celebrate 20th Anniversary]]></title>
	<summary type="html"><![CDATA[
Celebrating its 20th anniversary, 5.11 Tactical reflects on its journey from rock-climbing pants to a trusted provider of Purpose-Built Gear™ for public safety professionals and outdoor enthusiasts. CEO Francisco J. Morales expresses gratitude to customers and reaffirms the company's commitment to empowering individuals to "Always Be Ready" through dependable, innovative gear.
The post 5.11 Tactical to Celebrate 20th Anniversary appeared first on 5.11 Community.]]></summary>
	<content type="html"><![CDATA[]]></content>
	<dc:creator><![CDATA[]]></dc:creator>
	<published>Sat, 28 Jan 2023 07:43:26 +0000</published>
	<link rel="enclosure" href="https://community.511tactical.com/wp-content/uploads/2023/01/2301_MK_20thAnniv_SocialAssets_3x2.webp" type=""/>
	<full-content type="html"><![CDATA[]]></full-content>
	<feedzy:parent-source>5.11 Community</feedzy:parent-source>
	<error></error>
</entry>

Changes:

  • Added parsing for feedzy:parent-source tag into the feed.

Testing

  • Install the Pro plugin
  • Create a feed with multiple sources
  • On the Map Content, in the Content field, add item_full_content and item_source tags.
  • Import the feeds and check if the item source matches the article content.

image

image

Check before Pull Request is ready:

When `full_content` magic tag is present, the endpoint will create a single feed with all the data.

The feed is enhanced with custom tags under `feedzy` tag namespace.
@pirate-bot
Copy link
Contributor

pirate-bot commented Mar 12, 2024

Plugin build for 3777a5e is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Mar 12, 2024 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Mar 14, 2024
@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Mar 22, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 22, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Mar 22, 2024
@vytisbulkevicius vytisbulkevicius merged commit 19b0e4f into development Mar 28, 2024
12 of 13 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/full-content-import-source-per-feed branch March 28, 2024 11:28
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item source is Feedzy when using multiple feeds
4 participants