Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mime content type #912

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Fix/mime content type #912

merged 6 commits into from
Apr 10, 2024

Conversation

preda-bogdan
Copy link
Contributor

@preda-bogdan preda-bogdan commented Mar 29, 2024

Summary

Will get the mime type of the imported image from the Header Content-Type of the image that is downloaded, if the mime_content_type function is available will also use that to ensure the proper type.

This will prevent fatal errors in instances where the mime_content_type function might not be present.

Extended tests to also check for the attachments import.

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

  1. Unit tests should pass
  2. On a fresh instance where FileInfo PHP extension is not present
  3. Check that the import of a feed as an attachment will not trigger an error.

Check before Pull Request is ready:

Closes #909.

@preda-bogdan preda-bogdan linked an issue Mar 29, 2024 that may be closed by this pull request
@preda-bogdan preda-bogdan marked this pull request as ready for review April 3, 2024 07:35
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Apr 3, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Apr 3, 2024

Plugin build for 08df282 is ready 🛎️!

includes/admin/feedzy-rss-feeds-import.php Outdated Show resolved Hide resolved
@vytisbulkevicius vytisbulkevicius merged commit e507184 into development Apr 10, 2024
9 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/mime_content_type branch April 10, 2024 14:12
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if mime_content_type is available and show notification
4 participants