-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/706 #921
Fix/706 #921
Conversation
@GrigoreMihai Check the changes from here: https://github.com/Codeinwp/feedzy-rss-feeds-pro/pull/704/files#diff-d8a06b956d9b531f79139c5fa5b28ed8394685385718406591b2a62678ff5ba7R28-R30 WordPress 6.5 changed some class names and the E2E tests might not find the right items to interact with. If you run this locally check that you remove the old WordPress image from docker so that it will download the latest one. Also, consider adding a small unit test for the small changes you introduced. Let me know once you fix the tests so I can review the full changes. Thank you! |
🎉 This PR is included in version 4.4.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Adds a check to display the full error only for admin users.
Adds a unit test that checks for the errors to not be displayed for non admin users.
Will affect visual aspect of the product
NO
Test instructions
Follow the issue details. One important detail is that you need to test to a non admin user for example editor, author https://vertis.d.pr/i/nX0ddB .
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/706.