Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/706 #921

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Fix/706 #921

merged 5 commits into from
Apr 10, 2024

Conversation

GrigoreMihai
Copy link
Contributor

@GrigoreMihai GrigoreMihai commented Apr 9, 2024

Summary

Adds a check to display the full error only for admin users.

Adds a unit test that checks for the errors to not be displayed for non admin users.

Will affect visual aspect of the product

NO

Test instructions

Follow the issue details. One important detail is that you need to test to a non admin user for example editor, author https://vertis.d.pr/i/nX0ddB .

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/706.

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Apr 9, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Apr 9, 2024

Plugin build for 8e56406 is ready 🛎️!

@GrigoreMihai GrigoreMihai added the pr-checklist-skip Allow this Pull Request to skip checklist. label Apr 9, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Apr 9, 2024
@preda-bogdan
Copy link
Contributor

@GrigoreMihai Check the changes from here: https://github.com/Codeinwp/feedzy-rss-feeds-pro/pull/704/files#diff-d8a06b956d9b531f79139c5fa5b28ed8394685385718406591b2a62678ff5ba7R28-R30

WordPress 6.5 changed some class names and the E2E tests might not find the right items to interact with.

If you run this locally check that you remove the old WordPress image from docker so that it will download the latest one.

Also, consider adding a small unit test for the small changes you introduced.

Let me know once you fix the tests so I can review the full changes. Thank you!

@GrigoreMihai GrigoreMihai removed the pr-checklist-skip Allow this Pull Request to skip checklist. label Apr 10, 2024
@GrigoreMihai GrigoreMihai merged commit 07b0cad into development Apr 10, 2024
14 checks passed
@GrigoreMihai GrigoreMihai deleted the fix/706 branch April 10, 2024 13:58
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants