Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image import for images with spaces in url #923

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

preda-bogdan
Copy link
Contributor

Summary

Fixed import for images from feeds where the image might contain encoded white space in the URL.
Added unit test to check for this case.

Will affect the visual aspect of the product

NO

Screenshots

Mapping example for import image

Test instructions

  1. Use this feed to test with: https://fetchrss.com/rss/64e0dbc093190f2b1a5d40b264e22cf23a76e05a277d6673.xml
  2. Ensure [#item_image] is used inside the content and featured image from mapping. See the Screenshot example.
  3. Check that all images are imported.

Check before Pull Request is ready:

Closes #917.

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Apr 10, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Apr 10, 2024

Plugin build for be1b512 is ready 🛎️!

@preda-bogdan preda-bogdan linked an issue Apr 10, 2024 that may be closed by this pull request
@vytisbulkevicius vytisbulkevicius merged commit c957b08 into development Apr 10, 2024
9 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/image_import branch April 10, 2024 14:44
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some images are not set as featured when % is in the img src url.
4 participants