Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better checking for default image for the RSS Block #929

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Apr 16, 2024

Summary

Added a checker that detects if the Feedzy default image is used when the thumbnail option is set to auto in the RSS block.

Will affect visual aspect of the product

YES

Screenshots

image

image

Test instructions

Check before Pull Request is ready:

Closes #920

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Apr 16, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Apr 16, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Apr 17, 2024 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review April 17, 2024 13:12
@pirate-bot
Copy link
Contributor

Plugin build for 30038cb is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Apr 17, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel removed the pr-checklist-skip Allow this Pull Request to skip checklist. label Apr 17, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 510d320 into development Apr 18, 2024
25 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/img-fallback-on-feeds branch April 18, 2024 08:33
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback image displayed even when it's not set
3 participants