Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/image import non ascii #930

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

preda-bogdan
Copy link
Contributor

Summary

Similar to the spaces fix the URL was not passing the filter function.
Improved the URL sanitization before running the filter so that URLs are converted to ASCII and escaped.
Same as it happens inside the browser.
This should also allow for all valid URLs to pass the check.

Added test for this specific case with internalized URLs.

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

  1. Try to import a feed with internalized image URLs
  2. Check that the images are being imported.
  3. All tests should pass.

Check before Pull Request is ready:

Closes #928.

@preda-bogdan preda-bogdan changed the base branch from master to development April 17, 2024 07:58
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Apr 17, 2024
@pirate-bot
Copy link
Contributor

Plugin build for 0f8d13c is ready 🛎️!

Copy link
Contributor

@GrigoreMihai GrigoreMihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

Just a small NIT, maybe we could have a test just for the convert_url_to_ascii function, I think it will add a bit more clarity for future persons looking over the function.

@vytisbulkevicius vytisbulkevicius merged commit 8355268 into development May 30, 2024
10 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/image_import_non_ascii branch May 30, 2024 10:23
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images with some characters in the URL are not imported
4 participants