-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: first initial support for playwright #943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soare-Robert-Daniel
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
May 23, 2024
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
May 31, 2024
6 tasks
preda-bogdan
suggested changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few changes and concerns that you can check before moving forward with this.
Changes
|
preda-bogdan
approved these changes
Jun 5, 2024
Merged
🎉 This PR is included in version 4.4.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Warning
E2E for chained actions UI has been disabled since they are too flaky. The UI does not respond to tell to browser automation.
Details
To add Playwright support, I needed to update the
wp-scripts
package to a newer version. Since the packages were very old, many more upgrades were required to complete the process.One of them was upgrading the build JS commands. With the newer version, we get a modern compiler that uses modern JS; thus, the build files are now smaller. But also, we get a smarter lint , which was disabled for the moment, and it will be addressed separately since many issues have been reported.
With the upgrade, I also simplified the build process, simplifying and removing some old steps that were no longer needed.
With the
wp-scripts
andwp-env,
the writing test experience should be much smoother and help us maintain good peace with out goals.Note
The Tagify library used for feed settings is problematic because it uses some custom events that do not seem to trigger the data saving into the input field. Some workaround must be done (like directly injecting the values).
JS Build Files
Our JS build files for feeds import where queuing React from WordPress and also shipping another react version in the build files.
Will affect visual aspect of the product
NO
Test instructions
Check before Pull Request is ready:
Closes #931