Skip to content

Commit

Permalink
chore: optimize JS build
Browse files Browse the repository at this point in the history
  • Loading branch information
Soare-Robert-Daniel committed Nov 16, 2023
1 parent 848c30f commit e439837
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 18 deletions.
29 changes: 14 additions & 15 deletions assets/js/src/frontend/hgf.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,35 +78,36 @@ HFG.prototype.init = function (skipSidebar = false) {
*/
HFG.prototype.toggleMenuSidebar = function (toggle, target = null) {
const TOGGLE_CLASS_CONTAINER = '.menu-mobile-toggle';
const buttonsContainer = document.querySelectorAll(TOGGLE_CLASS_CONTAINER);
removeClass(document.body, sidebarClasses[1]);
const doc = document;
const buttonsContainer = doc.querySelectorAll(TOGGLE_CLASS_CONTAINER);
removeClass(doc.body, sidebarClasses[1]);

/**
* Elements to apply aria-hidden on
*/
const ariaShowOnToggle = document.querySelectorAll(
const ariaShowOnToggle = doc.querySelectorAll(
'#header-menu-sidebar, .hfg-ov'
);
const ariaHideOnToggle = document.querySelectorAll(
const ariaHideOnToggle = doc.querySelectorAll(
'.neve-skip-link, #content, .scroll-to-top, #site-footer, .header--row'
);

if (
(!NeveProperties.isCustomize &&
document.body.classList.contains(sidebarClasses[0])) ||
doc.body.classList.contains(sidebarClasses[0])) ||
toggle === false
) {
const navClickaway = document.querySelector('.nav-clickaway-overlay');
const navClickaway = doc.querySelector('.nav-clickaway-overlay');
if (navClickaway !== null) {
navClickaway.parentNode.removeChild(navClickaway);
}
addClass(document.body, sidebarClasses[1]);
removeClass(document.body, sidebarClasses[0]);
addClass(doc.body, sidebarClasses[1]);
removeClass(doc.body, sidebarClasses[0]);
removeClass(buttonsContainer, sidebarClasses[2]);
// Remove the hiding class after 1 second.
setTimeout(
function () {
removeClass(document.body, sidebarClasses[1]);
removeClass(doc.body, sidebarClasses[1]);
}.bind(this),
1000
);
Expand All @@ -117,17 +118,15 @@ HFG.prototype.toggleMenuSidebar = function (toggle, target = null) {
toggleAria(ariaHideOnToggle, false);
toggleAria(ariaShowOnToggle);
// Remove focus trap when closing.
document.dispatchEvent(new CustomEvent(NV_FOCUS_TRAP_END));
doc.dispatchEvent(new CustomEvent(NV_FOCUS_TRAP_END));
} else {
addClass(document.body, sidebarClasses[0]);
addClass(doc.body, sidebarClasses[0]);
addClass(buttonsContainer, sidebarClasses[2]);
if (target) {
document.dispatchEvent(
doc.dispatchEvent(
new CustomEvent(NV_FOCUS_TRAP_START, {
detail: {
container: document.getElementById(
'header-menu-sidebar'
),
container: doc.getElementById('header-menu-sidebar'),
close: closeNavSelector,
firstFocus: closeNavSelector + ',.menu-item a',
backFocus: target,
Expand Down
11 changes: 8 additions & 3 deletions rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,15 @@ const ROLLUP_MODERN = {
debug: true,
useBuiltIns: 'usage',
corejs: 3,
exclude: ['es.string.split', 'web.dom-collections.iterator'],
exclude: [
'es.string.split',
'web.dom-collections.iterator',
'@babel/plugin-transform-parameters',
],
},
],
],
babelHelpers: 'bundled',
};
const all_coverage = {
'assets/js/build/all/metabox.js': 'assets/js/src/metabox.js',
Expand All @@ -61,7 +66,7 @@ Object.keys(all_coverage).forEach(function (item) {
output: {
file: item,
format: 'iife',
sourcemap: 'inline',
sourcemap: process.env.ROLLUP_WATCH ? 'inline' : false,
},
plugins: [
multi(),
Expand All @@ -78,7 +83,7 @@ Object.keys(modern).forEach(function (item) {
output: {
file: item,
format: 'iife',
sourceMap: 'inline',
sourcemap: process.env.ROLLUP_WATCH ? 'inline' : false,
},
plugins: [
multi(),
Expand Down

0 comments on commit e439837

Please sign in to comment.