-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two H1 tags when Show Site Title is enabled #3984
Comments
@ineagu In this case, it's fine to use an H2 or something else for the Mobile title? Or Google won't like the hidden H1? |
Hey! As a user, I would say I don't care that much about it on our sites. As for how to approach the issue, I would look into what tool is the one that reports that and what a google lighthouse test is telling us about it. Tools can be faulty as well, nowadays is not really relevant if you have 0 or 5 H1, Google is smart enough to understand more than that, so if Google itself doesn't see this as an SEO issue, we can ignore it as well. If we wanna improve on this, the solution is not to make one of them an H2, the solution would be to clean up the DOM, and repeat this text only once, since if we assume search engines are stupid, they would see that text twice, which is not what we want. Even more, I don't think having H1 in the site title is the best practice, for most pages the H1 should be the title of a page or the post, which seems to be the case here; https://demosites.io/web-agency-gb/what-is-the-progressive-web-app-pwa-and-how-it-works/, so I am not sure why in the current issue it is h1, while in the demo is |
I think this might be there because, with Your latest posts option, there is no H1 on the home page; but I'm not 100% sure if this is why it works like this. |
🎉 This issue has been resolved in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
In the header Logo & Site Identity component, when the Show Site Title is enabled, there are two Heading 1 elements in the page. One is for the Desktop component and one for the Mobile one.
The problem is that this raises a warning when using an SEO plugin.
The only solution I found to this issue is with Neve Pro, to use the second Logo & Site Identity component on mobile devices where Show Site Title will be disabled on Mobile. However, for Neve free, there is no such workaround.
Step-by-step reproduction instructions
<h1
you will see there are two occurrencesScreenshots, screen recording, code snippet or Help Scout ticket
Reported here: https://secure.helpscout.net/conversation/2245485216/369844/
Environment info
https://pastebin.com/f6gRcuTw
Is the issue you are reporting a regression
No
The text was updated successfully, but these errors were encountered: