Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SEO site-title tag for homepage #4183

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

preda-bogdan
Copy link
Contributor

Summary

Changed the tag for site-title on mobile to use p instead of h1 the same as for all other pages where the site title should not be the main title. SEO will now see only the h1 used by the desktop on the homepage where usually no other main title is present.

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

  1. Create a new instance with Neve and set the home page to your latest posts
  2. Add the Logo & Site Identity component
  3. Set a site title if not already set
  4. Enable Show Site Title
  5. Check on the front-end homepage that only one h1 tag is present.

Check before Pull Request is ready:

Closes #3984.

@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 8, 2024
@preda-bogdan preda-bogdan linked an issue Jan 8, 2024 that may be closed by this pull request
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 8, 2024
@pirate-bot
Copy link
Collaborator

Plugin build for d642dc1 is ready 🛎️!

@irinelenache
Copy link
Contributor

@preda-bogdan Tested and the issue is fixed now 👍

@preda-bogdan preda-bogdan merged commit 62e452d into development Jan 26, 2024
18 checks passed
@preda-bogdan preda-bogdan deleted the fix/seo_brand_title_by_device branch January 26, 2024 10:59
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two H1 tags when Show Site Title is enabled
4 participants