Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Post Type assignment in Infinit scroll #4137

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 9, 2023

Summary

The post type was overridden with the value 'post' even if the args had its value. Now, it will act as the default value.

Will affect visual aspect of the product

NO

Screenshots

Before

image

After

image

Test instructions

  • Create a CPT and enable the archive for it
  • Create some posts for that type so the Infinite scroll can be triggered (You can also decrease the posts per page number in Dashboard > Settings > Reading)
  • Go to the CPT archive and check which posts are rendered when the infinite scroll is triggered

Check before Pull Request is ready:

Closes #.

The post type was overrided with the value 'post' even if the args had its own value. Now it will act as default value.
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Nov 9, 2023 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 9, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 9, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review November 9, 2023 11:58
@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 9, 2023

Plugin build for 5440e49 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 9, 2023
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue is fixed, but found a different problem:

  • Sometimes the rendered posts don't have the correct ordering depending on how i scroll the page i think https://vertis.d.pr/v/k83Qoc I see these 2 requests are always triggered in the correct order (page/2 , page/3) but sometimes the visible posts are from page/3 then page/2

The issue can be checked here:

https://unsightly-unicorn-hpvps.vertisite.cloud/properties/
heveneniki3906
4jiB3PcsXqYWp2zgL6UV

@Soare-Robert-Daniel
Copy link
Contributor Author

@irinelenache @vytisbulkevicius, let's make the reported problem a new issue since it requires another type of change unrelated to this issue.

@Soare-Robert-Daniel
Copy link
Contributor Author

@vytisbulkevicius, since the issue reported is now separated. I will mark it as Ready to Merge.

@preda-bogdan preda-bogdan merged commit a7cdb66 into development Nov 28, 2023
15 checks passed
@preda-bogdan preda-bogdan deleted the fix/infinit-scroll branch November 28, 2023 08:54
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite scroll loads normal posts on CPT archive
4 participants