Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/submenu long items wrap #4153

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Conversation

preda-bogdan
Copy link
Contributor

@preda-bogdan preda-bogdan commented Nov 23, 2023

Summary

I changed the style for the submenu items on mobile to account for very long menu items.
Item names now should wrap instead of overflowing.

Will affect the visual aspect of the product

YES

Screenshots

image

Test instructions

  1. On a fresh instance with Neve
  2. Create a menu where item names are very long
  3. Check that all long item names are wrapped and displayed on multiple lines if required.

Check before Pull Request is ready:

Closes #4147.

@preda-bogdan preda-bogdan changed the base branch from master to development November 23, 2023 08:02
@preda-bogdan preda-bogdan marked this pull request as ready for review November 29, 2023 14:45
@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 29, 2023

Plugin build for 312dfda is ready 🛎️!

@irinelenache
Copy link
Contributor

@preda-bogdan Tested and the issue is fixed now, also tested the Neve pro PR and everything's fine there too 🚀

@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed has conflicts labels Dec 22, 2023
@preda-bogdan preda-bogdan merged commit 60702ef into development Jan 26, 2024
17 checks passed
@preda-bogdan preda-bogdan deleted the fix/submenu_long_items_wrap branch January 26, 2024 11:09
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submenu content not wrapped
4 participants