Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sub Menu observer for Pro Modules #4160

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 28, 2023

Summary

This a completion of this recommendation https://github.com/Codeinwp/neve-pro-addon/pull/2673#pullrequestreview-1717999564

I added a reusable script that checks the Custom Layout status and adds/removes the Sub Menus based on module status.

This will offer visual feedback to the user regarding the module status.

Will affect visual aspect of the product

YES

Screenshots

2023-11-07_14-21-08.mp4

Test instructions

⚠️ You will to test with Neve Pro, and it must be tested with this PR https://github.com/Codeinwp/neve-pro-addon/pull/2701 . If the PR has been merged, use the release build.

  • When you toggle Custom Layouts, you should see how the Sub Menu is added or removed.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2671

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 28, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 28, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review November 28, 2023 13:18
@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 28, 2023

Plugin build for 0053829 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 28, 2023
@preda-bogdan preda-bogdan merged commit baf5c89 into development Nov 29, 2023
16 checks passed
@preda-bogdan preda-bogdan deleted the fix/submenu-observer branch November 29, 2023 09:20
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants