Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the opening of Search Icon in Mobile Sidebar. #4166

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 6, 2023

Summary

The search icon no longer be opened because of the CSS property that nullifies the click event.

This regression was introduced in this commit 320f2ee for this issue #3729 (which seems to have a rich history)

I added an exception to the CSS selector to ensure that Search Icon is not targeted. The identification is made via the unique class .floating.

Will affect visual aspect of the product

NO

Screenshots

2023-12-06_15-30-54.mp4

Test instructions

  • Add the Search Icon in the Mobile Sidebar
  • Check if you can open/close.

Note

It will be good to check other search components to see if they have the same problem with click.

Check before Pull Request is ready:

Closes #4017

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 6, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Dec 6, 2023 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 6, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 6, 2023 13:44
@pirate-bot
Copy link
Collaborator

Plugin build for 981f363 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 6, 2023
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue is fixed now 👍 I see that no matter what Open behaviour i select, it will be the same when the icon is in the mobile sidebar https://vertis.d.pr/v/fKuTRT If this is expected, should we add a note in the customizer or in the docs?

@Soare-Robert-Daniel
Copy link
Contributor Author

@irinelenache, the icon search in the sidebar is set to a behavior named floating. I think we can put a note in the docs if people expect something else.

@preda-bogdan preda-bogdan merged commit 31d31d7 into development Jan 26, 2024
40 checks passed
@preda-bogdan preda-bogdan deleted the fix/mobile-search-icon branch January 26, 2024 12:51
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search icon issues on mobile
4 participants