Fix the opening of Search Icon in Mobile Sidebar. #4166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The search icon no longer be opened because of the CSS property that nullifies the click event.
This regression was introduced in this commit 320f2ee for this issue #3729 (which seems to have a rich history)
I added an exception to the CSS selector to ensure that Search Icon is not targeted. The identification is made via the unique class
.floating
.Will affect visual aspect of the product
NO
Screenshots
2023-12-06_15-30-54.mp4
Test instructions
Note
It will be good to check other search components to see if they have the same problem with click.
Check before Pull Request is ready:
Closes #4017