Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: woocommerce notices for wc8.5 #4189 #4191

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

preda-bogdan
Copy link
Contributor

Summary

With the release of WooCommerce v8.5.0, the notices have been changed to use a new HTML structure.
I added new rules to style the notices as they were previously based on the customizer settings.

Will affect the visual aspect of the product

NO

Screenshots

Product notice BEFORE wc.8.5 image
Product notice AFTER wc.8.5 image
Cart notices BEFORE wc.8.5 image image
Cart notices AFTER wc.8.5 image image
Checkout notices BEFORE wc.8.5 image
Checkout notices AFTER wc.8.5 image

Test instructions

Check before Pull Request is ready:

Closes #4189.

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Jan 17, 2024
@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 17, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Jan 17, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 17, 2024

Plugin build for 92a9e0a is ready 🛎️!

Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid solution. I commented on better use of SCSS features, but not a blocker since the result is the same.

@preda-bogdan
Copy link
Contributor Author

@Soare-Robert-Daniel Thank you for the recommendation, I implemented the changes.

@irinelenache
Copy link
Contributor

@preda-bogdan Tested and the issue is fixed now 🚀

@preda-bogdan preda-bogdan merged commit 5736080 into development Jan 26, 2024
15 checks passed
@preda-bogdan preda-bogdan deleted the fix/woo_notices_wc8.5 branch January 26, 2024 10:57
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants