-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: woocommerce notices for wc8.5 #4189 #4191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid solution. I commented on better use of SCSS features, but not a blocker since the result is the same.
@Soare-Robert-Daniel Thank you for the recommendation, I implemented the changes. |
@preda-bogdan Tested and the issue is fixed now 🚀 |
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
With the release of WooCommerce v8.5.0, the notices have been changed to use a new HTML structure.
I added new rules to style the notices as they were previously based on the customizer settings.
Will affect the visual aspect of the product
NO
Screenshots
Product notice BEFORE wc.8.5
Product notice AFTER wc.8.5
Cart notices BEFORE wc.8.5
Cart notices AFTER wc.8.5
Checkout notices BEFORE wc.8.5
Checkout notices AFTER wc.8.5
Test instructions
Check before Pull Request is ready:
Closes #4189.