Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shop page sidebar issue with latest release #4329

Closed
wants to merge 1 commit into from

Conversation

girishpanchal30
Copy link
Contributor

Summary

Fixed sidebar disappearing issue with the latest release.

Will affect visual aspect of the product

Yes

Screenshots

https://tinyurl.com/2yjvm6zb

Check before Pull Request is ready:

Closes #4328

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 22, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 22, 2024
@pirate-bot
Copy link
Collaborator

Plugin build for 3223127 is ready 🛎️!

@vytisbulkevicius
Copy link
Contributor

@girishpanchal30 can you check the check failing here?

@girishpanchal30
Copy link
Contributor Author

@vytisbulkevicius It looks like all demo sites are displaying a broken layout.
Ref: https://github.com/Codeinwp/neve/blob/master/e2e-tests/specs/visual-regression/starter-sites.spec.ts#L7-L18

image

@selul selul removed the request for review from Soare-Robert-Daniel December 3, 2024 07:55
@selul
Copy link
Contributor

selul commented Dec 3, 2024

@girishpanchal30 please rebase with dev and review the tests to be fixed.

@vytisbulkevicius
Copy link
Contributor

@selul this PR should have been closed as the issue was fixed when we made the release with changes reverted - #4333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shop page sidebar not working in latest update
4 participants