Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Migrate the performance test #1885

Merged
merged 15 commits into from
Nov 14, 2023
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 27, 2023

Closes #1884

Summary

Migrating the performance test.

⚠️ At the moment of writing this, some functions are missing from deps since they have not been released yet. Check https://www.npmjs.com/package/@wordpress/e2e-test-utils-playwright?activeTab=code to see if startTracing is present


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 27, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Sep 27, 2023 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 9, 2023 10:20
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 9, 2023
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 9, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 284.35 KB 284.35 KB 0 B (0.00%)
Blocks 1.5 MB 1.5 MB 121 B (0.01%)
CSS 91.69 KB 91.71 KB 24 B (0.03%)
Dashboard 176.79 KB 176.79 KB 0 B (0.00%)
Export Import 89.53 KB 89.53 KB 0 B (0.00%)
Pro 354.06 KB 354.09 KB 23 B (0.01%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 9, 2023

Plugin build for 7c88a20 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 9, 2023

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 193.15, firstPaint: 573.75, domContentLoaded: 1685.95, loaded: 1687.85, firstContentfulPaint: 9794.35, firstBlock: 19155.35, type: 52.52, minType: 46.86, maxType: 60.28, typeContainer: 13.07, minTypeContainer: 10.9, maxTypeContainer: 17.9, focus: 71.85, minFocus: 61.92, maxFocus: 88.16, inserterOpen: 35.07, minInserterOpen: 25.27, maxInserterOpen: 49.14, inserterSearch: 10.39, minInserterSearch: 7.86, maxInserterSearch: 12.5, inserterHover: 43.67, minInserterHover: 37.82, maxInserterHover: 54.4, listViewOpen: 204.57, minListViewOpen: 179.74, maxListViewOpen: 223.78

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel Any update here?

@HardeepAsrani HardeepAsrani merged commit 60129ef into development Nov 14, 2023
@HardeepAsrani HardeepAsrani deleted the dev/migrate-performance branch November 14, 2023 21:26
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate performance test to Playwright
3 participants