-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- recovery for changing view state
- Loading branch information
Showing
1 changed file
with
7 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d63c540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果当前tabA出于刷新状态,然后你切换tab到tabB页面正好此时网络比较弱的情况下tabA界面的数据仍然没有加载出来如果我再切换到tabA界面此时应该是出于刷新状态(正常情况下),上面这样修改之后手动结束了刷新状态是不是有问题?
d63c540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1283 你试试这个 PR
@JoinPerson
d63c540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修复切换tab栏时,header没有重置位置的bug 这个bug只会在iOS >= 11.0才会出现么?
d63c540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
调整后的代码好像只针对self.window == nil 且 iOS >= 11.0做了代码执行逻辑调整。
d63c540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果只是self.window == nil 且 iOS >= 11.0才出现这个bug 这样调整代码后,当 self.window == nil 且 iOS >= 11.0时会执行后面的代码(原来的逻辑是不会执行的)会不会带来新的问题?
d63c540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (self.window == nil) return; 这行代码是不是去掉就行了 不管这个条件成不成立都执行后面的代码会有问题么?
d63c540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有写注释的啊. iOS 10 之前的版本有影响.
d63c540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS < 11 和 > 11 有不同的顶部栏 滞留 bug. 不是同一个.
但都出在这句上.