Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose of resized mask image when calculating diffs (#67) #70

Merged
merged 1 commit into from
Jul 28, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ImageSharpCompare/ImageSharpCompare.cs
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
/// <param name="pathExpectedImage"></param>
/// <param name="resizeOption"></param>
/// <returns>Mean and absolute pixel error</returns>
public static ICompareResult CalcDiff(string pathActualImage, string pathExpectedImage, ResizeOption resizeOption = ResizeOption.DontResize)

Check warning on line 163 in ImageSharpCompare/ImageSharpCompare.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

All 'CalcDiff' method overloads should be adjacent.

Check warning on line 163 in ImageSharpCompare/ImageSharpCompare.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

All 'CalcDiff' method overloads should be adjacent.

Check warning on line 163 in ImageSharpCompare/ImageSharpCompare.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

All 'CalcDiff' method overloads should be adjacent.

Check warning on line 163 in ImageSharpCompare/ImageSharpCompare.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

All 'CalcDiff' method overloads should be adjacent.

Check warning on line 163 in ImageSharpCompare/ImageSharpCompare.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

All 'CalcDiff' method overloads should be adjacent.

Check warning on line 163 in ImageSharpCompare/ImageSharpCompare.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

All 'CalcDiff' method overloads should be adjacent.

Check warning on line 163 in ImageSharpCompare/ImageSharpCompare.cs

View workflow job for this annotation

GitHub Actions / deployTest

All 'CalcDiff' method overloads should be adjacent.

Check warning on line 163 in ImageSharpCompare/ImageSharpCompare.cs

View workflow job for this annotation

GitHub Actions / deployTest

All 'CalcDiff' method overloads should be adjacent.
{
using var actual = Image.Load(pathActualImage);
using var expected = Image.Load(pathExpectedImage);
Expand Down Expand Up @@ -419,6 +419,7 @@
{
grown.Item1?.Dispose();
grown.Item2?.Dispose();
grown.Item3?.Dispose();
}
}

Expand Down
Loading